Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mellanox]: Enable CPLD update progress bar #4363

Merged
merged 2 commits into from
Apr 14, 2020
Merged

[mellanox]: Enable CPLD update progress bar #4363

merged 2 commits into from
Apr 14, 2020

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Apr 3, 2020 •
edited
Loading

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

Summary:

  1. Enabled CPLD update progress bar
  2. Changed cpldupdate invocation: make output realtime

- What I did

  • Enabled CPLD update progress bar

- How I did it

  • Enabled inbuilt cpldupdate progress bar with --print-progress

- How to verify it

  1. Install CPLD FW:
fwutil install chassis component CPLD1 fw /tmp/FUI000091_Burn_SN3800_CPLD000120_REV0600_CPLD000165_REV0400_CPLD000166_REV0300_CPLD000167_REV0100.vme
  1. Observe progress bar:
New firmware will be installed, continue? [y/N]: y
Installing firmware:
    FUI000091_Burn_SN3800_CPLD000120_REV0600_CPLD000165_REV0400_CPLD000166_REV0300_CPLD000167_REV0100.vme
                 Lattice Semiconductor Corp.

             ispVME(tm) V12.2 Copyright 1998-2012.

               Customized for Mellanox products.

Using GPIO update!
Processing virtual machine file (FUI000091_Burn_SN3800_CPLD000120_REV0600_CPLD000165_REV0400_CPLD000166_REV0300_CPLD000167_REV0100.vme)......

... <--- progress bar

- Description for the changelog

  • Added CPLD update progress bar

- A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@volodymyrsamotiy
Copy link
Collaborator

Please add more details to the PR desription according to the listed below:

  • Describe why this change is needed
  • Describe all the changes that were done as part of this PR
    (there is also change of the way how cpldupdate tool is called)
  • Add details to the "How I did it" section
  • Describe verification steps under the "How to verify it" section
  • Add details to the "Description for the changelog" section

stephenxs
stephenxs previously approved these changes Apr 8, 2020
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2020

This pull request introduces 1 alert when merging 314ff6bfef4ca3bc186ab032d6176142f1a5f9bd into 7405f8c - view on LGTM.com

new alerts:

  • 1 for Unused import

liat-grozovik
liat-grozovik previously approved these changes Apr 10, 2020
View reviewed changes
@nazariig
[mellanox]: Enable CPLD update progress bar.
12f262d 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
[mellanox]: Remove unused import - sys.
c96c90b 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
Copy link
Collaborator Author

@jleveque if no concerns - please help to merge

@jleveque jleveque merged commit 3c4f311 into sonic-net:master Apr 14, 2020
abdosi pushed a commit that referenced this pull request Apr 15, 2020
@nazariig @abdosi
[mellanox]: Enable CPLD update progress bar (#4363)
c3e030b 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
@nazariig @tiantianlv
[mellanox]: Enable CPLD update progress bar (sonic-net#4363)
e22de76 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyrsamotiy volodymyrsamotiy volodymyrsamotiy approved these changes

@jleveque jleveque jleveque approved these changes

@liat-grozovik liat-grozovik liat-grozovik left review comments

@stephenxs stephenxs stephenxs left review comments

Assignees
No one assigned
Labels
Enhancement ➕ Included in 201911 Branch Platform: Mellanox Request for 201911 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nazariig @volodymyrsamotiy @jleveque @stephenxs @liat-grozovik @abdosi